Resolved Repair doesn't work for non custom durability items

Discussion in 'Bug Reports' started by Ceroish, Nov 4, 2019.

  1. Ceroish

    Ceroish New Member

    Joined:
    Oct 31, 2017
    Messages:
    2
    Likes Received:
    0
    Version/Build Number:
    4.7.20 / 5.1-SNAPSHOT-37


    Server Version/Paper Build Number:
    Paper version git-Paper-214 (MC: 1.14.4)


    Please describe the bug:
    When using any item that has the repair function, it reacts in different ways for different use cases.
    --------------
    For vanilla items, it just does nothing at all. Doesn't even swap items. (It'd be nice if this feature could actually work on non MMOItems gear, as well)


    For MMOItems items that are damaged, but have no custom durability set, the Repair Item will be consumed, with a notice in chat, while no durability is repaired.
    upload_2019-11-5_0-36-28.png
    upload_2019-11-5_0-36-41.png
    upload_2019-11-5_0-36-53.png


    For MMOItems items that have custom durability, but aren't set to Unbreakable, the Repair Item will be consumed, with a notice in chat, while no durability is repaired. (The custom durability goes up though, of course.)
    Take note of the Sword's durability, compared to the custom durability
    upload_2019-11-5_0-38-42.png


    For MMOItems items that are unbreakable and have custom durability, the repair feature works as intended.



    Paste any relevant configs:

    Code:
    DOUBLE_OR_NOTHING:
      material: IRON_AXE
      lore:
      - '&7&oA very powerful yet hard'
      - '&7&oto manipulate weapon...'
      - '&7&oBe very careful!'
      critical-strike-power: 800.0=900.0
      critical-strike-chance: 48.0=52.0
      attack-damage: 1.4=1.5
      attack-speed: 1.0=1.1
      required-level: 10.0
      enchants:
        unbreaking: 5
      hide-enchants: true
      name: '&b&l&o"Double or Nothing"'
      gem-sockets:
      - Red
      - Uncolored
      - Green
      - Blue
      ability:
        on-hit:
          type: SLOW
          mode: ON_HIT
          cooldown: 30.0
          duration: 4.0
          amplifier: 2.0
      pvp-damage: 12.0
    Code:
    CUTLASS:
      material: IRON_SWORD
      attack-damage: 6.0=8.0
      attack-speed: 1.6=1.8
      lore:
      - '&7Slightly better than an iron sword.'
      required-level: 3.0
      tier: COMMON
      name: '&fSharp Cutlass'
      max-durability: 300.0
    (Sharp Cutlass didn't generate with unbreaking, using 4.7.20)

    Code:
    SHARP_FLINT:
    material: FLINT
    name: '&fSharp Flint'
    tier: COMMON
    repair: 25.0

    Paste any relevant error logs:

    None

    Provide a full latest.log:

    None Needed
     
    #1
    Last edited: Nov 4, 2019
  2. Elspar2

    Elspar2 New Member

    Joined:
    Jun 26, 2018
    Messages:
    7
    Likes Received:
    1
    This is working as intended. The repair option only affects the custom durability of the item. The use of custom durability is to set the tool to unbreakable to allow different textures to be used when the tool is set to a certain minecraft damage. For example /give @p minecraft:diamond_axe 1 1 has a different texture than /give @p minecraft:diamond_axe 1 0
     
    #2
  3. Ceroish

    Ceroish New Member

    Joined:
    Oct 31, 2017
    Messages:
    2
    Likes Received:
    0
    It can't be working fully as intended, if the repair consumable works on a damaged item even if it has no custom durability set, and is consumed without doing anything. Especially when it says it repaired XX amount of durability in the chat on use.

    This leads to repair consumables being wasted, if there is a misclick while trying to shuffle things around in an inventory.
     
    #3
  4. Indyuce

    Indyuce Developer
    Developer Supporter

    Joined:
    Jun 18, 2019
    Messages:
    18
    Likes Received:
    0
    There was indeed an issue with vanilla durability and repair consumables, it should be fixed in the latest dev build.
     
    #4

Share This Page